-
Notifications
You must be signed in to change notification settings - Fork 71
feat(mcp): build flagset from mcp input schema to parse args #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
burmudar
wants to merge
6
commits into
wb/mcp-rawname-name
Choose a base branch
from
wb/mcp-flagset-inputschema
base: wb/mcp-rawname-name
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+203
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
30adde0 to
75745b3
Compare
965b1cd to
8c88192
Compare
75745b3 to
926edde
Compare
8c88192 to
c6d1745
Compare
926edde to
0d18f1c
Compare
37b35d8 to
10b9829
Compare
f26eeef to
912eaff
Compare
10b9829 to
c93e6a0
Compare
912eaff to
b917a41
Compare
c93e6a0 to
619a3a0
Compare
b917a41 to
bae1fb1
Compare
619a3a0 to
c3d97d0
Compare
bae1fb1 to
d8c7c8e
Compare
c3d97d0 to
90c48d3
Compare
90c48d3 to
1c9d1aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We build a flagset from the input schema. This allows the input schema to be the
source of truth of the flags on the mcp command and ensures we are up to date with
the schema stored in the repository.
Test plan
Added a test case and also executed locally with
commit-search