add docker image build + push to CI #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
couple questions:
|
eseliger
reviewed
Apr 15, 2020
Co-Authored-By: Erik Seliger <erikseliger@me.com>
not easily, theoretically you could configure .travis.yml to run on non-master branches but its more trouble than its worth, and in cases like this I recommend just doing a best-effort then testing in Our buildkite CI in our main repository has better dry-run capabilities, so things are better/different there. |
emidoots
reviewed
Apr 16, 2020
.travis.yml
Outdated
| - provider: script | ||
| script: curl -sL https://git.io/goreleaser | bash | ||
| script: | ||
| - echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin |
There was a problem hiding this comment.
Note: You'll need to add this to the env/global secure section above as a Travis encrypted secret. Username can be hard-coded here in plaintext though.
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* add docker image build + push to CI * change docker image version tags to be consistent with our other images * add git to image for lsif upload * Update Dockerfile documentation Co-Authored-By: Erik Seliger <erikseliger@me.com> * add docker credentials Co-authored-by: Erik Seliger <erikseliger@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.