diff --git a/CHANGELOG.md b/CHANGELOG.md index d7685a3355..14b4f46364 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,8 @@ All notable changes to `src-cli` are documented in this file. ### Fixed +- Log files created by `src campaigns [preview|apply]` are deleted again after successful execution. This was a regression and is not new behaviour. If steps failed to execute or the `-keep-logs` flag is set the log files are not cleaned up. + ## 3.21.0 ### Added diff --git a/internal/campaigns/log.go b/internal/campaigns/log.go index 9b5dade0fd..a5cdd3d134 100644 --- a/internal/campaigns/log.go +++ b/internal/campaigns/log.go @@ -90,6 +90,11 @@ func (tl *TaskLogger) Close() error { if tl.errored || tl.keep { return nil } + + if err := os.Remove(tl.f.Name()); err != nil { + return errors.Wrapf(err, "cleaning up log file %s", tl.f.Name()) + } + return nil }