From 5f0bb9df0af6bd50d667096defd05ac756734630 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Tue, 13 Oct 2020 15:31:39 -0700 Subject: [PATCH 1/3] release: add a note about DEVELOPMENT.md I'm not saying I forgot to check the checklist in DEVELOPMENT.md before releasing today, but... uh, I'm not saying I _didn't_ forget, either. --- release.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/release.sh b/release.sh index af2c733cff..de5f725171 100755 --- a/release.sh +++ b/release.sh @@ -1,5 +1,8 @@ #!/usr/bin/env bash +# If you haven't already read DEVELOPMENT.md, please stop and do so. Running +# this script is _not_ the first thing you need to do to make a release. + set -euf -o pipefail if ! echo "$VERSION" | grep -Eq '^[0-9]+\.[0-9]+\.[0-9]+$'; then From e9f92e7a3fe1c536e2ffa11c3ecdf93a728d1002 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Tue, 13 Oct 2020 15:50:13 -0700 Subject: [PATCH 2/3] Make the DEVELOPMENT.md nudge a question instead. --- release.sh | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/release.sh b/release.sh index de5f725171..a68304c49e 100755 --- a/release.sh +++ b/release.sh @@ -1,7 +1,10 @@ #!/usr/bin/env bash -# If you haven't already read DEVELOPMENT.md, please stop and do so. Running -# this script is _not_ the first thing you need to do to make a release. +# Have you read DEVELOPMENT.md before running this script? +# +# No? Please stop and do so. +# +# Yes? You know what to do! set -euf -o pipefail From b96fc314331918c51b2ce61686fb89b6bbfa1a63 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Tue, 13 Oct 2020 16:06:03 -0700 Subject: [PATCH 3/3] Move the comment to a prompt. --- release.sh | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/release.sh b/release.sh index a68304c49e..2d1b278369 100755 --- a/release.sh +++ b/release.sh @@ -1,13 +1,17 @@ #!/usr/bin/env bash -# Have you read DEVELOPMENT.md before running this script? -# -# No? Please stop and do so. -# -# Yes? You know what to do! - set -euf -o pipefail +read -p 'Have you read DEVELOPMENT.md? [y/N] ' -n 1 -r +echo +case "$REPLY" in + Y|y) ;; + *) + echo 'Please read the Releasing section of DEVELOPMENT.md before running this script.' + exit 1 + ;; +esac + if ! echo "$VERSION" | grep -Eq '^[0-9]+\.[0-9]+\.[0-9]+$'; then echo "\$VERSION is not in MAJOR.MINOR.PATCH format" exit 1