Skip to content

Conversation

@uwedeportivo
Copy link
Contributor

withCfg swaps in a new config that points at dot-com but the request uses the client created above the swap and captured in the closure.

Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof. Good catch! I bet that was awful to debug, sorry about that.

@uwedeportivo uwedeportivo merged commit 95707ab into main Dec 15, 2020
@uwedeportivo uwedeportivo deleted the extensions_copy_fix branch December 15, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants