From 3fbcb6cf48fa332e3b92a7d2a516b744843f6c62 Mon Sep 17 00:00:00 2001
From: Adam Harvey <adam@adamharvey.name>
Date: Tue, 29 Dec 2020 21:35:59 -0800
Subject: [PATCH] ci: remove AppVeyor

GitHub Actions can now do everything AppVeyor could for us, and more
(macOS support), and less jankily (_why_ can't go test invocations call
back into themselves, only on AppVeyor?).
---
 .gitattributes              |  1 +
 .github/workflows/go-ci.yml |  9 ++++++---
 DEVELOPMENT.md              |  8 --------
 appveyor.yml                | 24 ------------------------
 4 files changed, 7 insertions(+), 35 deletions(-)
 create mode 100644 .gitattributes
 delete mode 100644 appveyor.yml

diff --git a/.gitattributes b/.gitattributes
new file mode 100644
index 0000000000..fa1385d99a
--- /dev/null
+++ b/.gitattributes
@@ -0,0 +1 @@
+* -text
diff --git a/.github/workflows/go-ci.yml b/.github/workflows/go-ci.yml
index 0ee271576e..c90e9c7e6f 100644
--- a/.github/workflows/go-ci.yml
+++ b/.github/workflows/go-ci.yml
@@ -5,14 +5,17 @@ on:
 
 jobs:
   go-test:
-    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        go-version: [1.14.x, 1.15.x]
+        os: [ubuntu-latest, macos-latest, windows-latest]
+    runs-on: ${{ matrix.os }}
     steps:
       - name: Checkout
         uses: actions/checkout@v2
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.15
-      - run: go get -d -t ./...
+          go-version: ${{ matrix.go-version }}
       - run: go test -i ./...
       - run: go test -race -v ./...
diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md
index 74720a238b..1d3f6a0178 100644
--- a/DEVELOPMENT.md
+++ b/DEVELOPMENT.md
@@ -38,11 +38,3 @@ For example, suppose we have the the recommended versions.
 If a new feature is added to a new `3.91.6` release of src-cli and this change requires only features available in Sourcegraph `3.99`, then this feature should also be present in a new `3.85.8` release of src-cli. Because a Sourcegraph instance will automatically select the highest patch version, all non-breaking changes should increment only the patch version. 
 
 Note that if instead the recommended src-cli version for Sourcegraph `3.99` was `3.90.4` in the example above, there is no additional step required, and the new patch version of src-cli will be available to both Sourcegraph versions.
-
-## AppVeyor builds
-
-We use AppVeyor to test `src-cli` on Windows.
-
-Configure the AppVeyor builds by editing the `appveyor.yml` file and logging in to AppVeyor and changing the settings there.
-
-Login with your GitHub account, switch to the `sourcegraph` account and change the settings here: https://ci.appveyor.com/project/sourcegraph/src-cli/settings/environment
diff --git a/appveyor.yml b/appveyor.yml
deleted file mode 100644
index 19f43dc7c4..0000000000
--- a/appveyor.yml
+++ /dev/null
@@ -1,24 +0,0 @@
-version: "{build}"
-clone_folder: c:\gopath\src\github.com\sourcegraph\src-cli
-
-environment:
-  GOROOT: 'c:\go'
-  GOPATH: c:\gopath
-  GOVERSION: 1.14
-  PATH: '%GOPATH%\bin;%GOROOT%\bin;%PATH%'
-  GO111MODULE: 'on'
-
-install:
-  # Install the specific Go version.
-  - rmdir c:\go /s /q
-  - appveyor DownloadFile https://storage.googleapis.com/golang/go%GOVERSION%.windows-amd64.msi
-  - msiexec /i go%GOVERSION%.windows-amd64.msi /q
-  - go version
-  - go env
-
-build_script:
-  - go version
-  - go get -v -t ./...
-
-test_script:
-  - go test ./...