Fix all errors reported by golint-ci #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnugget
commented
Jan 20, 2021
| fileDiffsOnce sync.Once | ||
| } | ||
|
|
||
| func (ts *TaskStatus) Clone() *TaskStatus { |
There was a problem hiding this comment.
Unused function that's also broken because it copies a sync.Once.
efritz
approved these changes
Jan 20, 2021
eseliger
approved these changes
Jan 20, 2021
Strum355
approved these changes
Jan 20, 2021
|
|
||
| file.WriteString(content) | ||
| if _, err := file.WriteString(content); err != nil { | ||
| return err |
There was a problem hiding this comment.
This would break out of the loop, which is maybe what we want, but just double checking the assumption 🙂
There was a problem hiding this comment.
I think that's fine, yeah.
LawnGnome
approved these changes
Jan 20, 2021
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Fix all errors reported by golint-ci * See if that fixes the windows build * Use os.Chmod() instead of (*os.File).Chmod() to fix windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used VS Code again and got sick of all the warnings popping up. So, here we are. I fixed all the errors reported by running
golint-ci runin the root ofsrc-cli.