Skip to content

Add gitHead to extension manifest #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2021
Merged

Add gitHead to extension manifest #500

merged 3 commits into from
Mar 26, 2021

Conversation

@efritz
Copy link
Contributor

@efritz efritz commented Mar 25, 2021

No description provided.

@efritz efritz requested review from felixfbecker and mrnugget March 25, 2021 14:27
@efritz efritz mentioned this pull request Mar 25, 2021
Closed
felixfbecker
felixfbecker approved these changes Mar 25, 2021
View reviewed changes
@efritz efritz requested a review from eseliger March 25, 2021 15:59
mrnugget
mrnugget approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@mrnugget mrnugget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, no opinions on whether to make this a required thing for extensions or not.

@efritz efritz merged commit 1bdc8a9 into main Mar 26, 2021
@efritz efritz deleted the ef/extensions-git-head branch March 26, 2021 16:42
scjohns pushed a commit that referenced this pull request Apr 24, 2023
@efritz
Add gitHead to extension manifest (#500)
ebe35e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrnugget mrnugget mrnugget approved these changes

@eseliger eseliger eseliger approved these changes

+1 more reviewer

@felixfbecker felixfbecker felixfbecker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@efritz @mrnugget @felixfbecker @eseliger