Fix skip errors flag #539
Merged
Fix skip errors flag #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't return the specs in case of an error, so we would ignore the error, but still have no changeset specs uploaded, which resulted in the generated batch spec in the preview being empty.
courier-new
approved these changes
May 17, 2021
mrnugget
added a commit
that referenced
this pull request
May 18, 2021
mrnugget
added a commit
that referenced
this pull request
May 18, 2021
mrnugget
added a commit
that referenced
this pull request
May 19, 2021
…Coordinator/Service/executor (#536) * Broken build with TaskStatusHubThing * Introduce Coordinator * Replace TaskStatusHubThing with TaskStatusCollection * Clean up the executor * Clean up handling of ExecutionOpts * Fix missing rename * Make executor property and status a runtime arg * Create separate tests for Coordinator * Fix tests for Coordinator * More test cleanup * Re-add missing test * Re-add transfromGroup test but its passing, what * Add test for transform group * Add test helpers * Backport fix from #539 * Update internal/batches/executor/coordinator.go Co-authored-by: Adam Harvey <aharvey@sourcegraph.com> Co-authored-by: Adam Harvey <aharvey@sourcegraph.com>
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
We didn't return the specs in case of an error, so we would ignore the error, but still have no changeset specs uploaded, which resulted in the generated batch spec in the preview being empty.
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
…Coordinator/Service/executor (#536) * Broken build with TaskStatusHubThing * Introduce Coordinator * Replace TaskStatusHubThing with TaskStatusCollection * Clean up the executor * Clean up handling of ExecutionOpts * Fix missing rename * Make executor property and status a runtime arg * Create separate tests for Coordinator * Fix tests for Coordinator * More test cleanup * Re-add missing test * Re-add transfromGroup test but its passing, what * Add test for transform group * Add test helpers * Backport fix from #539 * Update internal/batches/executor/coordinator.go Co-authored-by: Adam Harvey <aharvey@sourcegraph.com> Co-authored-by: Adam Harvey <aharvey@sourcegraph.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't return the specs in case of an error, so we would ignore the error, but still have no changeset specs uploaded, which resulted in the generated batch spec in the preview being empty.