Skip to content

Conversation

@eseliger
Copy link
Member

@eseliger eseliger commented Aug 17, 2021

Now that this property isn't required anymore, we can get rid of that part. Honors the feature flag for optional publish values.

Closes https://github.com/sourcegraph/sourcegraph/issues/22180

Now that this property isn't required anymore, we can get rid of that part. Honors the feature flag for optional publish values.
@eseliger eseliger requested a review from a team August 17, 2021 11:25
Copy link
Contributor

@LawnGnome LawnGnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eseliger eseliger merged commit 3eb98de into main Aug 17, 2021
@eseliger eseliger deleted the es/no-publish-example branch August 17, 2021 20:36
Copy link
Contributor

@courier-new courier-new left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactor here as well! Thanks so much Erik! 😄

@eseliger
Copy link
Member Author

Involuntarily 😆 The feature flags are only available in the service layer :)

scjohns pushed a commit that referenced this pull request Apr 24, 2023
Now that this property isn't required anymore, we can get rid of that part. Honors the feature flag for optional publish values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove publish from src batch new

4 participants