Slight refactor of package structures #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseliger
commented
Aug 23, 2021
Comment on lines
-609
to
-622
| const findDirectoryQuery = ` | ||
| query DirectoriesContainingFile($query: String!) { | ||
| search(query: $query, version: V2) { | ||
| results { | ||
| results { | ||
| __typename | ||
| ... on FileMatch { | ||
| file { path } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ` |
eseliger
commented
Aug 23, 2021
Comment on lines
-661
to
+648
| a.WriteString("query DirectoriesContainingFile() {\n") | ||
| a.WriteString("query DirectoriesContainingFile {\n") |
There was a problem hiding this comment.
that's illegal in graphql, but our library has an open ticket for it. It might break in the future, though.
eseliger
commented
Aug 23, 2021
mrnugget
approved these changes
Aug 23, 2021
eseliger
force-pushed
the
es/refactor-packages
branch
from
6deb37a to
920b73f
Compare
eseliger
force-pushed
the
es/refactor-packages
branch
from
920b73f to
96a4d8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.