Fix nil-panic if repository has no default branch #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the fix for the issue reported in sourcegraph/customer#537. The problem: 1. Sometimes repositories don't have a default branch, because they're being cloned or updated by Sourcegraph. See code here: https://sourcegraph.com/github.com/sourcegraph/sourcegraph@1cbb9023b0c77e6fa132298df1b2b5a768288d67/-/blob/internal/vcs/git/default_branch.go?L6 2. We skip the repositories with no repositories, *but too late*. With the introduction of `.batchignore` we added additional code that broke that check.
eseliger
approved these changes
Oct 22, 2021
I checked: no, it's fine. We do the has-branch check at the top of the process: https://github.com/sourcegraph/sourcegraph/blob/1cbb9023b0c77e6fa132298df1b2b5a768288d67/enterprise/internal/batches/service/workspace_resolver.go#L141-L145 |
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
This is the fix for the issue reported in sourcegraph/customer#537. The problem: 1. Sometimes repositories don't have a default branch, because they're being cloned or updated by Sourcegraph. See code here: https://sourcegraph.com/github.com/sourcegraph/sourcegraph@1cbb9023b0c77e6fa132298df1b2b5a768288d67/-/blob/internal/vcs/git/default_branch.go?L6 2. We skip the repositories with no repositories, *but too late*. With the introduction of `.batchignore` we added additional code that broke that check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for the issue reported in https://github.com/sourcegraph/customer/issues/537.
The problem:
git.DefaultBranch.batchignorewe added additional code that broke that check.