Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batches: Cache filesystem mount #795

Merged
merged 14 commits into from Jun 29, 2022
Merged

batches: Cache filesystem mount #795

merged 14 commits into from Jun 29, 2022

Conversation

Piszmog
Copy link
Contributor

@Piszmog Piszmog commented Jun 23, 2022

Closes #37216.

  • Removed the cache checks to enable caching for mount
  • Renamed AllowMountPaths to IsRemote for usage in the caching (enables caching for filesystem only)

Test plan

Go Unit tests and manual testing. See #37363

@Piszmog Piszmog changed the title Rc/mount caching batches: Cache mount Jun 23, 2022
@Piszmog Piszmog changed the title batches: Cache mount batches: Cache filesystem mount Jun 23, 2022
Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

internal/batches/executor/task.go Outdated Show resolved Hide resolved
@Piszmog Piszmog marked this pull request as ready for review June 24, 2022 14:52
@Piszmog Piszmog requested a review from a team June 24, 2022 14:52
Copy link
Contributor

@LawnGnome LawnGnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a changelog item just to say this works now, and get it out there! Nice work. 👍

@Piszmog Piszmog merged commit 0755599 into main Jun 29, 2022
@Piszmog Piszmog deleted the rc/mount-caching branch June 29, 2022 14:47
scjohns pushed a commit that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add caching strategy for files mounted on step containers
3 participants