From b0972f58a1495669aa9ffadabb77f9c0b68a035b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=86gir=20M=C3=A1ni=20Hauksson?= <54936225+sourcehawk@users.noreply.github.com> Date: Thu, 4 Jun 2026 00:36:33 +0200 Subject: [PATCH] fix(component): add trailing period to grace-period failure message --- pkg/component/converge.go | 2 +- pkg/component/converge_test.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/component/converge.go b/pkg/component/converge.go index cefde9cd..cb4d9cdb 100644 --- a/pkg/component/converge.go +++ b/pkg/component/converge.go @@ -130,7 +130,7 @@ func (c reconcileResults) graceSummary() concepts.GraceStatusWithReason { if !anyGraceful { return concepts.GraceStatusWithReason{ Status: concepts.GraceStatusDown, - Reason: "Component failed to converge within grace period", + Reason: "Component failed to converge within grace period.", } } diff --git a/pkg/component/converge_test.go b/pkg/component/converge_test.go index 03801670..c6ceef31 100644 --- a/pkg/component/converge_test.go +++ b/pkg/component/converge_test.go @@ -146,6 +146,7 @@ func TestConvergeResultsGraceSummary(t *testing.T) { require.NoError(t, results.evaluateGrace()) summary := results.graceSummary() assert.Equal(t, concepts.GraceStatusDown, summary.Status) + assert.Equal(t, "Component failed to converge within grace period.", summary.Reason) }) t.Run("should aggregate grace status of alive resources", func(t *testing.T) {