Skip to content

reimplement: OpenSHC::Random::RNG 100%#65

Merged
TheRedDaemon merged 6 commits into
mainfrom
reimpl/OpenSHC__Random__RNG
May 22, 2026
Merged

reimplement: OpenSHC::Random::RNG 100%#65
TheRedDaemon merged 6 commits into
mainfrom
reimpl/OpenSHC__Random__RNG

Conversation

@gynt
Copy link
Copy Markdown
Contributor

@gynt gynt commented May 13, 2026

  OpenSHC::Random::RNG::setTimeBasedSeed (0x46a740) is 87.50% similar to the original
  OpenSHC::Random::RNG::populateRNG1040 (0x46a760) is 93.75% similar to the original
  OpenSHC::Random::RNG::nextRandomNumber2 (0x46a7d0) is 100.00% similar to the original
  OpenSHC::Random::RNG::nextRandomNumber1 (0x46a800) is 100.00% similar to the original
  OpenSHC::Random::RNG::Constructor_RNG (0x471810) is 100.00% similar to the original

The reimplementations for setTimeBasedSeed and populateRNG1040 are not 100% because they use lib functions that are currently set to non-reimplemented by REIMPLEMENTED_CRT.

@gynt gynt requested a review from TheRedDaemon May 13, 2026 10:51
Comment thread src/OpenSHC/Random/RNG/Constructor_RNG.cpp Outdated
Comment thread src/OpenSHC/Random/RNG/nextRandomNumber1.cpp Outdated
Comment thread src/OpenSHC/Random/RNG/populateRNG1040.cpp Outdated
Comment thread status/addresses-SHC-3BB0A8C1.txt
@gynt gynt force-pushed the reimpl/OpenSHC__Random__RNG branch from 7ff2753 to 166b5bf Compare May 22, 2026 12:25
@gynt gynt requested a review from TheRedDaemon May 22, 2026 12:27
Copy link
Copy Markdown
Contributor

@TheRedDaemon TheRedDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove the other explicit non-early returns?

@gynt gynt requested a review from TheRedDaemon May 22, 2026 21:01
@TheRedDaemon TheRedDaemon merged commit d8a0c7d into main May 22, 2026
1 check passed
@TheRedDaemon TheRedDaemon deleted the reimpl/OpenSHC__Random__RNG branch May 22, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants