Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Credo to v1.1.5 #18

Merged
merged 8 commits into from Feb 20, 2020
Merged

Upgrade Credo to v1.1.5 #18

merged 8 commits into from Feb 20, 2020

Conversation

wevtimoteo
Copy link
Member

@wevtimoteo wevtimoteo commented Feb 19, 2020

Engine

  • Use Credo.Execution
  • Manually invoke append default config task for Credo.Execution
  • Categorize new checks
  • Upgrade Elixir to 1.10 and Erlang to 21.3
    • Travis CI
    • Dockerfile
  • Introduce .tool-versions file

Credo

Changelog

1.1.5

  • Add JSON output to categories and explain commands
  • Include number of executed checks in summary
  • Fix wrong trigger in SinglePipe

1.1.4

  • Fix name parsing bug in UnusedVariableNames
  • Fix bug when redefining operators in FunctionNames
  • Fix false positive in Specs

1.1.3

  • Improve warning message about skipped checks
  • Fix false positive in FunctionNames
  • Fix typespec in IssueMeta
  • Add AliasAs check to list of optional checks

1.1.2

  • Fix bug in Heredocs regarding indentation
  • Fix bug in FunctionNames when using unquote/1 in guards
  • Fix bug in FunctionNames when defining sigil_ functions for uppercase sigils

1.1.1

  • Fix incompatibilities between Elixir 1.9, Credo.Code.Token and Credo.Code.InterpolationHelper
  • Fix error in Heredocs with certain UTF-8 chars
  • New param for ParenthesesOnZeroArityDefs: use [parens: true] to force presence of parentheses on zero arity defs

1.1.0

  • Credo now requires Elixir 1.5 and Erlang/OTP 19
  • Fix false negative in DuplicatedCode
  • PipeChainStart has been made opt-in

Plugin Support

Credo now supports plugins that run alongside Credo's own analysis. While Credo provided the ability to write custom checks since v0.4.0, users can now access the complete toolset of Credo to create their own commands, require compilation, run external tools and still include the results in Credo's standard report.

Please refer to Credo's README as well as the Credo Demo Plugin for further information on how to get started.

New checks

  • Credo.Check.Refactor.WithClauses

This will be used by asdf to determine which versions we're using for
Erlang and Elixir.
Previously, this was accomplished inside `combine_configs`. Now we
should use `Credo.Execution` and `AppendDefaultConfig` task.
@wevtimoteo wevtimoteo self-assigned this Feb 19, 2020
@wevtimoteo wevtimoteo added task upgrade New Credo version labels Feb 19, 2020
@wevtimoteo wevtimoteo merged commit a625178 into master Feb 20, 2020
@wevtimoteo wevtimoteo deleted the upgrade-credo-to-1.1.5 branch February 20, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task upgrade New Credo version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants