Skip to content

Group related canonicalizer rules #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jviotti merged 3 commits into from
Apr 17, 2026
Merged

Group related canonicalizer rules #731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e484dc
Group related canonicalizer rules
jviotti Apr 17, 2026
a1e71b9
More
jviotti Apr 17, 2026
fdd63e2
Fixes
jviotti Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/alterschema/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ sourcemeta_library(NAMESPACE sourcemeta PROJECT blaze NAME alterschema
SOURCES alterschema.cc schema_rule.cc transformer.cc
# Canonicalizer
canonicalizer/additional_items_implicit.h
canonicalizer/additional_properties_implicit.h
canonicalizer/comment_drop.h
canonicalizer/const_as_enum.h
canonicalizer/dependencies_to_any_of.h
Expand All @@ -28,7 +27,6 @@ sourcemeta_library(NAMESPACE sourcemeta PROJECT blaze NAME alterschema
canonicalizer/exclusive_minimum_integer_to_minimum.h
canonicalizer/extends_to_array.h
canonicalizer/if_then_else_implicit.h
canonicalizer/implicit_array_keywords.h
canonicalizer/implicit_contains_keywords.h
canonicalizer/implicit_object_keywords.h
canonicalizer/items_implicit.h
Expand All @@ -39,13 +37,10 @@ sourcemeta_library(NAMESPACE sourcemeta PROJECT blaze NAME alterschema
canonicalizer/min_items_given_min_contains.h
canonicalizer/min_length_implicit.h
canonicalizer/min_properties_covered_by_required.h
canonicalizer/min_properties_implicit.h
canonicalizer/minimum_can_equal_integer_fold.h
canonicalizer/minimum_can_equal_true_drop.h
canonicalizer/multiple_of_implicit.h
canonicalizer/optional_property_implicit.h
canonicalizer/properties_implicit.h
canonicalizer/property_names_implicit.h
canonicalizer/recursive_anchor_false_drop.h
canonicalizer/required_property_implicit.h
canonicalizer/type_array_to_any_of.h
Expand Down
10 changes: 0 additions & 10 deletions src/alterschema/alterschema.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ auto WALK_UP_IN_PLACE_APPLICATORS(const JSON &root, const SchemaFrame &frame,
}

#include "canonicalizer/additional_items_implicit.h"
#include "canonicalizer/additional_properties_implicit.h"
#include "canonicalizer/comment_drop.h"
#include "canonicalizer/const_as_enum.h"
#include "canonicalizer/dependencies_to_any_of.h"
Expand All @@ -132,7 +131,6 @@ auto WALK_UP_IN_PLACE_APPLICATORS(const JSON &root, const SchemaFrame &frame,
#include "canonicalizer/exclusive_minimum_integer_to_minimum.h"
#include "canonicalizer/extends_to_array.h"
#include "canonicalizer/if_then_else_implicit.h"
#include "canonicalizer/implicit_array_keywords.h"
#include "canonicalizer/implicit_contains_keywords.h"
#include "canonicalizer/implicit_object_keywords.h"
#include "canonicalizer/items_implicit.h"
Expand All @@ -143,13 +141,10 @@ auto WALK_UP_IN_PLACE_APPLICATORS(const JSON &root, const SchemaFrame &frame,
#include "canonicalizer/min_items_given_min_contains.h"
#include "canonicalizer/min_length_implicit.h"
#include "canonicalizer/min_properties_covered_by_required.h"
#include "canonicalizer/min_properties_implicit.h"
#include "canonicalizer/minimum_can_equal_integer_fold.h"
#include "canonicalizer/minimum_can_equal_true_drop.h"
#include "canonicalizer/multiple_of_implicit.h"
#include "canonicalizer/optional_property_implicit.h"
#include "canonicalizer/properties_implicit.h"
#include "canonicalizer/property_names_implicit.h"
#include "canonicalizer/recursive_anchor_false_drop.h"
#include "canonicalizer/required_property_implicit.h"
#include "canonicalizer/type_array_to_any_of.h"
Expand Down Expand Up @@ -277,8 +272,6 @@ auto add(SchemaTransformer &bundle, const AlterSchemaMode mode) -> void {
bundle.add<UnevaluatedPropertiesToAdditionalProperties>();
bundle.add<IfThenElseImplicit>();
bundle.add<ImplicitObjectKeywords>();
bundle.add<PropertyNamesImplicit>();
Copy link
Copy Markdown

@augmentcode augmentcode Bot Apr 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By folding PropertyNamesImplicit (and related rules) into ImplicitObjectKeywords, the standalone rule names disappear from traces and can’t be individually excluded/removed via SchemaTransformer::remove / x-exclude. If external users rely on those granular rule names, this becomes a user-visible behavior change.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

bundle.add<ImplicitArrayKeywords>();
bundle.add<ImplicitContainsKeywords>();
bundle.add<ExtendsToArray>();
bundle.add<DisallowToArrayOfSchemas>();
Expand Down Expand Up @@ -355,11 +348,9 @@ auto add(SchemaTransformer &bundle, const AlterSchemaMode mode) -> void {
bundle.add<MinItemsGivenMinContains>();
bundle.add<MinPropertiesCoveredByRequired>();
bundle.add<MinLengthImplicit>();
bundle.add<MinPropertiesImplicit>();
bundle.add<MultipleOfImplicit>();
bundle.add<DivisibleByImplicit>();
bundle.add<MaxDecimalImplicit>();
bundle.add<PropertiesImplicit>();
bundle.add<ItemsImplicit>();
}

Expand Down Expand Up @@ -427,7 +418,6 @@ auto add(SchemaTransformer &bundle, const AlterSchemaMode mode) -> void {
bundle.add<EmptyDependenciesDrop>();
bundle.add<EmptyDependentSchemasDrop>();
bundle.add<EmptyDependentRequiredDrop>();
bundle.add<AdditionalPropertiesImplicit>();
Copy link
Copy Markdown

@augmentcode augmentcode Bot Apr 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing AdditionalPropertiesImplicit here effectively moves the additionalProperties defaulting earlier (now via ImplicitObjectKeywords), which means RequiredPropertiesInProperties (it requires !schema.defines("additionalProperties")) may no longer run for Draft 3–7 object schemas. That can change the canonicalized shape (e.g., required entries no longer being materialized under properties) and potentially break downstream assumptions/tests.

Severity: high

Other Locations
  • src/alterschema/canonicalizer/implicit_object_keywords.h:60
  • src/alterschema/common/required_properties_in_properties.h:36

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

bundle.add<AdditionalItemsImplicit>();
bundle.add<RequiredPropertyImplicit>();
bundle.add<OptionalPropertyImplicit>();
Expand Down
45 changes: 0 additions & 45 deletions src/alterschema/canonicalizer/additional_properties_implicit.h
View file
Open in desktop

This file was deleted.

70 changes: 0 additions & 70 deletions src/alterschema/canonicalizer/implicit_array_keywords.h
View file
Open in desktop

This file was deleted.

Loading
Loading