Skip to content

Upgrade Core and Blaze#915

Merged
jviotti merged 1 commit into
mainfrom
new-upgrade
May 22, 2026
Merged

Upgrade Core and Blaze#915
jviotti merged 1 commit into
mainfrom
new-upgrade

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented May 22, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 54 files

Re-trigger cubic

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 22, 2026

🤖 Augment PR Summary

Summary: Updates the vendored Sourcemeta Core and Blaze dependencies to newer upstream revisions, and adapts JSON BinPack’s build/test setup to the new Blaze module layout.

Changes:

  • Bumps pinned core and blaze SHAs in dependency manifests.
  • Extends JSON BinPack’s package config to require Blaze’s new bundle component.
  • Updates E2E test runner build to link and include Blaze’s new format library.
  • Splits Blaze functionality into additional sub-libraries (frame, bundle, format) and wires them into Blaze’s CMake options and package config.
  • Moves schema wrapping logic into alterschema and introduces dedicated frame_error error types.
  • Adjusts Blaze internal targets to link against the new modules where needed.
  • Updates Core compiler defaults to gate optimization-only flags outside Debug and tweaks test builds to disable LTO for faster linking.

Technical Notes: Blaze’s CMake/package changes are largely about making the new module boundaries explicit (headers and link targets) so downstreams can request only the components they need.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

add_subdirectory(src/foundation)
endif()

if(BLAZE_FRAME)
Copy link
Copy Markdown

@augmentcode augmentcode Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLAZE_FRAME/BLAZE_BUNDLE/BLAZE_FORMAT appear to assume BLAZE_FOUNDATION (and for bundle/format also BLAZE_FRAME) is enabled; if someone disables the prerequisite option, CMake will fail later when adding subdirectories/targets. Consider adding an explicit configure-time dependency check so invalid option combinations fail with a clearer error.

Severity: medium

Other Locations
  • vendor/blaze/CMakeLists.txt:61
  • vendor/blaze/CMakeLists.txt:65

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@jviotti jviotti merged commit 01757b7 into main May 22, 2026
14 checks passed
@jviotti jviotti deleted the new-upgrade branch May 22, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant