Properly make use of the Vary HTTP header#1037
Merged
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
|
This pull request is abnormally large and would use a significant amount of tokens to review. If you still wish to review it, comment "augment review" and we will review it. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 155 files
Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Re-trigger cubic
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 15dd4a6 | Previous: d659402 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
379 ms |
411 ms |
0.92 |
Add one schema (100 existing) |
158 ms |
29 ms |
5.45 |
Add one schema (1000 existing) |
94 ms |
88 ms |
1.07 |
Add one schema (10000 existing) |
819 ms |
697 ms |
1.18 |
Update one schema (1 existing) |
17 ms |
21 ms |
0.81 |
Update one schema (101 existing) |
93 ms |
29 ms |
3.21 |
Update one schema (1001 existing) |
86 ms |
87 ms |
0.99 |
Update one schema (10001 existing) |
825 ms |
718 ms |
1.15 |
Cached rebuild (1 existing) |
5 ms |
6 ms |
0.83 |
Cached rebuild (101 existing) |
7 ms |
8 ms |
0.88 |
Cached rebuild (1001 existing) |
26 ms |
30 ms |
0.87 |
Cached rebuild (10001 existing) |
224 ms |
255 ms |
0.88 |
Index 100 schemas |
749 ms |
660 ms |
1.13 |
Index 1000 schemas |
1397 ms |
1680 ms |
0.83 |
Index 10000 schemas |
16881 ms |
13981 ms |
1.21 |
Index 10000 schemas (custom meta-schema) |
110780 ms |
143830 ms |
0.77 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 15dd4a6 | Previous: d659402 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
394 ms |
380 ms |
1.04 |
Add one schema (100 existing) |
35 ms |
33 ms |
1.06 |
Add one schema (1000 existing) |
99 ms |
94 ms |
1.05 |
Add one schema (10000 existing) |
787 ms |
923 ms |
0.85 |
Update one schema (1 existing) |
25 ms |
25 ms |
1 |
Update one schema (101 existing) |
34 ms |
33 ms |
1.03 |
Update one schema (1001 existing) |
100 ms |
96 ms |
1.04 |
Update one schema (10001 existing) |
801 ms |
796 ms |
1.01 |
Cached rebuild (1 existing) |
8 ms |
8 ms |
1 |
Cached rebuild (101 existing) |
11 ms |
11 ms |
1 |
Cached rebuild (1001 existing) |
35 ms |
33 ms |
1.06 |
Cached rebuild (10001 existing) |
286 ms |
280 ms |
1.02 |
Index 100 schemas |
641 ms |
629 ms |
1.02 |
Index 1000 schemas |
1594 ms |
1553 ms |
1.03 |
Index 10000 schemas |
13668 ms |
13516 ms |
1.01 |
Index 10000 schemas (custom meta-schema) |
144711 ms |
132308 ms |
1.09 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com