Skip to content

Revert "Docker Build Failing" #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: base-sha/7164c29dd4f366c375dd46af8fe6a05dd5f53013
Choose a base branch
from
Open

Revert "Docker Build Failing" #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dockerhub-base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
uses: nikhilbadyal/ghactions/.github/workflows/dockerhub-push.yml@main
if: github.repository == 'nikhilbadyal/docker-py-revanced'
with:
IMAGE_TAG: nikhilbadyaldevelops/docker-py-revanced-base:latest
IMAGE_TAG: ${{ github.repository }}-base:latest
FILE: Dockerfile-base
secrets:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/dockerhub.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ jobs:
dockerhub-push:
uses: nikhilbadyal/ghactions/.github/workflows/dockerhub-push.yml@main
if: github.repository == 'nikhilbadyal/docker-py-revanced'
with:
IMAGE_TAG: nikhilbadyaldevelops/docker-py-revanced:latest
secrets:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM nikhilbadyaldevelops/docker-py-revanced-base
FROM nikhilbadyal/docker-py-revanced-base

# Copy and install Python dependencies
COPY requirements.txt .
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ You can use any of the following methods to build.
```
2. Run script with
```shell
docker run -v "$(pwd)"/apks:/app/apks/ nikhilbadyaldevelops/docker-py-revanced
Copy link

@SourceryAI SourceryAI May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code_refinement): Update to README ensures consistency with new image naming.

This change is crucial to maintain consistency in documentation with the actual image names used in deployment. It helps avoid confusion for end-users trying to pull the correct image.

Suggested change
docker run -v "$(pwd)"/apks:/app/apks/ nikhilbadyaldevelops/docker-py-revanced
docker run -v "$(pwd)"/apks:/app/apks/ nikhilbadyal/docker-py-revanced

Copy link

@SourceryAI SourceryAI May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment correct?

Copy link

@SourceryAI SourceryAI May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment helpful?

Copy link

@SourceryAI SourceryAI May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment type correct?

Copy link

@SourceryAI SourceryAI May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment area correct?

Copy link

@SourceryAI SourceryAI May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What type of LLM test could this comment become?

  • 👍 - this comment is really good/important and we should always make it
  • 👎 - this comment is really bad and we should never make it
  • no reaction - don't turn this comment into an LLM test

docker run -v "$(pwd)"/apks:/app/apks/ nikhilbadyal/docker-py-revanced
```
You can pass the below environment variables (See notes) with the `-e` flag or use the `--env-file`
[flag](https://docs.docker.com/engine/reference/commandline/run/#options).
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: '3.9'

services:
revanced:
image: nikhilbadyaldevelops/docker-py-revanced
image: nikhilbadyal/docker-py-revanced
container_name: revanced-builder
env_file:
- .env
Expand Down