From 5a870f5776d4a578298069b9db5cb8d9dbe59cef Mon Sep 17 00:00:00 2001 From: Connor Tumbleson Date: Tue, 6 Dec 2022 11:37:33 -0500 Subject: [PATCH] refactor: use try-with-resources w/ copyFile --- .../src/main/java/com/rnfs2/RNFSManager.java | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/android/src/main/java/com/rnfs2/RNFSManager.java b/android/src/main/java/com/rnfs2/RNFSManager.java index 89137c62..4f79049e 100755 --- a/android/src/main/java/com/rnfs2/RNFSManager.java +++ b/android/src/main/java/com/rnfs2/RNFSManager.java @@ -320,16 +320,15 @@ public void copyFile(String filepath, String destPath, ReadableMap options, Prom } private void copyFile(String filepath, String destPath) throws IOException, IORejectionException { - InputStream in = getInputStream(filepath); - OutputStream out = getOutputStream(destPath, false); - - byte[] buffer = new byte[1024]; - int length; - while ((length = in.read(buffer)) > 0) { - out.write(buffer, 0, length); + try (InputStream in = getInputStream(filepath)) { + try (OutputStream out = getOutputStream(destPath, false)) { + byte[] buffer = new byte[1024]; + int length; + while ((length = in.read(buffer)) > 0) { + out.write(buffer, 0, length); + } + } } - in.close(); - out.close(); } @ReactMethod