Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some comments in apache2.conf to make more sense with the out-… #546

Merged
merged 1 commit into from Aug 7, 2018

Conversation

kbuchsicf
Copy link
Contributor

Change some comments in apache2.conf to make more sense with the out-of-the-box configuration. Documentation correction for markdown syntax.

Description

Default configuration is a bit more rational.

Issues Resolved

[List any existing issues this PR resolves]

Check List

…of-the-box configuration. Documentation correction for markdown syntax.
@kbuchsicf
Copy link
Contributor Author

This PR does not incorporate my fixes (from the other PR) that ensure the service name is appropriately set for RHEL, CentOS platforms. It should be httpd there, not apache2. As it stands, the cookbook is broken on those platforms without the change.

@damacus
Copy link
Member

damacus commented Aug 7, 2018

Thanks. The service name has been fixed on master in the library helper.

@damacus damacus merged commit dc37a52 into sous-chefs:master Aug 7, 2018
@lock
Copy link

lock bot commented Aug 7, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants