Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making all set actions explicit. #46

Merged
merged 3 commits into from Oct 15, 2011

Conversation

Projects
None yet
2 participants
@ryansch
Copy link
Contributor

commented Oct 13, 2011

This will use the 'do' keyword for newer rvms and 'exec' for older rvms.

This is my first pass at functionality. I've got it working in both test environments with rvm 1.6.5 and rvm head. If you like it, I'll add some documentation.

Making all set actions explicit.
This will use the 'do' keyword for newer rvms.
module SetHelpers
def rvm_do(user = nil)
# Use Gem's version comparing code to compare the two strings
if Gem::Version.new(VersionCache.fetch_version(user)) <= Gem::Version.new("1.8.6")

This comment has been minimized.

Copy link
@ryansch

ryansch Oct 13, 2011

Author Contributor

@fnichol: If you hate abusing Gem this way, we can pull in versionomy (https://github.com/dazuma/versionomy) to do it instead.

@fnichol

This comment has been minimized.

Copy link
Collaborator

commented Oct 14, 2011

Freaking awesome dude! I just started working on this problem and found I missed reading the github pull request email. Pretty much the same implementation path too :) Let me run this through a VM and I'll get this pulled.

@ryansch

This comment has been minimized.

Copy link
Contributor Author

commented Oct 14, 2011

:-D Glad you like it! This cookbook has solved so many of my rvm+chef issues.

fnichol added a commit that referenced this pull request Oct 15, 2011

fnichol added a commit that referenced this pull request Oct 15, 2011

@fnichol fnichol merged commit 99a2a30 into sous-chefs:master Oct 15, 2011

@fnichol

This comment has been minimized.

Copy link
Collaborator

commented Oct 15, 2011

This looks to do the trick, thanks to @ryansch

phlipper added a commit to newleaders/chef-rvm that referenced this pull request Feb 1, 2012

phlipper added a commit to newleaders/chef-rvm that referenced this pull request Feb 1, 2012

phlipper added a commit to newleaders/chef-rvm that referenced this pull request Feb 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.