Fixed an edge case, & changed default nssm parameters

Added exit code 1 as an acceptable return code within
`nssm_service_installed?`. If AppRotateOnline is not set
for nssm, it will only rotate the logs when the service
is restarted. Changed the default nssm parameters so
that logs are rotated when they reach 20 MB in size.

attributes/default.rb

@@ -47,8 +47,9 @@
   'AppDirectory'     => join_path(data_prefix_path, 'data'),
   'AppStdout'        => join_path(config_prefix_path, 'stdout.log'),
   'AppStderr'        => join_path(config_prefix_path, 'error.log'),
-  'AppRotateSeconds' => 86_400,
-  'AppRotateFiles'   => 1
+  'AppRotateFiles'   => 1,
+  'AppRotateOnline'  => 1,
+  'AppRotateBytes'   => 20_000_000
 }
 
 default['consul']['checksums'] = {

libraries/consul_service_linux.rb

@@ -91,7 +91,7 @@ def action_disable
       end
 
       def service_options(service)
-        service.command(new_resource.command new_resource.config_file, new_resource.config_dir)
+        service.command(new_resource.command(new_resource.config_file, new_resource.config_dir))
         service.directory(new_resource.data_dir)
         service.user(new_resource.user)
         service.environment(new_resource.environment)

libraries/helpers.rb

@@ -58,7 +58,7 @@ def correct_version?(executable, version)
     end
 
     def binary_checksum(item)
-      node['consul']['checksums'].fetch(binary_filename item)
+      node['consul']['checksums'].fetch(binary_filename(item))
     end
 
     def binary_filename(item)
@@ -127,7 +127,9 @@ def nssm_params
     end
 
     def nssm_service_installed?
-      exit_code = shell_out!(%{"#{nssm_exe}" status consul}, returns: [0, 3]).exitstatus
+      # 1 is command not found
+      # 3 is service not found
+      exit_code = shell_out!(%{"#{nssm_exe}" status consul}, returns: [0, 1, 3]).exitstatus
       exit_code == 0 ? true : false
     end