Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use configfile instead of hardcoding values into init file #12

Merged
merged 1 commit into from Jun 6, 2014

Conversation

Projects
None yet
2 participants
@bkw
Copy link
Contributor

commented Jun 6, 2014

This PR makes use of a config json in the config dir.
It is rebased to your current master, so it still uses the artificial console_ui path for the web ui, and would need further adjustment should you decide to merge #11.
Just tell me to rebase and I'll happily do so.

@johnbellone

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2014

I merged #11 please rebase this.

@bkw

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2014

rebased.

@johnbellone

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2014

I really hate JSON configuration files. I would much rather prefer if we were able to use a template for this kind of stuff.

johnbellone added a commit that referenced this pull request Jun 6, 2014

Merge pull request #12 from bkw/useConfigDir
use configfile instead of hardcoding values into init file

@johnbellone johnbellone merged commit b08ad16 into sous-chefs:master Jun 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.