Added docker_container action :create (wrapper to 'docker create').#242
Merged
tduffield merged 2 commits intoNov 26, 2014
Merged
Conversation
Contributor
Author
|
Please note that the current kitchen.yml on master does not run the minitest specs (no |
Contributor
Author
|
To make this PR usable I still need to improve the docker_container :redeploy action to make so that:
If I leave the redeploy action as it is now, it may surprise the user to see a container that has been created (not run) then redeployed to be running after the redeployment. There is a similar issue with services: when using created (not run) containers as a system services, the associated system service for the created container should not be enabled by default. |
tduffield
pushed a commit
that referenced
this pull request
Nov 26, 2014
Added docker_container action :create (wrapper to 'docker create').
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple PR adds a new :create action to the docker_container LWRP.
The action wraps the
docker createcommand (introduced with docker 1.3.0) which is the same asdocker runexcept that it does not start the created container. Thedocker createcommand supports the same args as thedocker runcommand except for a few (detach, security-opt, rm and sig-proxy if I believe the manual page).