Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana_dashboard doesn't allow uppercase titles #64

Closed
runningman84 opened this issue Jul 16, 2015 · 5 comments

Comments

@runningman84
Copy link

commented Jul 16, 2015

is there any reason for forbidding uppercase names here?

         * grafana_dashboard[MYDASH] action create_if_missing

           ================================================================================
           Error executing action `create_if_missing` on resource 'grafana_dashboard[MYDASH]'
           ================================================================================

           RuntimeError
           ------------
           MYDASH did not match the name (MYDASH) in the json
@lanyonm

This comment has been minimized.

Copy link
Collaborator

commented Jul 16, 2015

There are three values we're trying to reconcile:

  • dashboard lwrp name
  • json filename
  • grafana dashboard name (the :slug used for lookup)

As I recall, it's not possible to have an uppercase dashboard :slug in Grafana. If that's no longer the case in future releases we should be able to alleviate this limitation. Does that answer your question?

@lanyonm lanyonm added the 2.x label Jul 16, 2015
@runningman84

This comment has been minimized.

Copy link
Author

commented Jul 16, 2015

That's ok for me, the error message was just misleading here.

@lanyonm lanyonm self-assigned this Jul 16, 2015
lanyonm added a commit that referenced this issue Jul 17, 2015
lanyonm added a commit that referenced this issue Jul 17, 2015
@lanyonm

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2015

@JonathanTron,
What do you think about this change to improve dashboard lwrp error logging: master...improve-err-msgs?

@JonathanTron

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2015

Seems good to me, if someone have problem understanding what failed from error message we are generating then it's a bug. Thanks to both of you for working it out.

@lanyonm lanyonm closed this in c5b7c85 Jul 21, 2015
@lanyonm lanyonm added this to the chef-grafana 2.1 milestone Aug 7, 2015
@lock

This comment has been minimized.

Copy link

commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.