New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement + possible fix in config.js template #1

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@iiro

iiro commented Mar 23, 2014

Changes:

  • config.js
    • Graphite host comes now from role search
    • removed the "use strict"; for some reason the Grafana didn´t load at all with that one...

I used version 1.5.1 of Grafana - installed from zip file.

@JonathanTron

This comment has been minimized.

Show comment
Hide comment
@JonathanTron

JonathanTron Mar 23, 2014

Collaborator

Hi, thanks for taking the time to send this pull-request.

About the config.js, it's taken from the grafana's config.sample.js and I use it successfully on production with "use strict";, can you explain what don't work for you and with which browser?

About the graphite url change, I'm not convinced. Using directly the graphite host + forcing the port is not acceptable to me. The nginx config I've put in the cookbook is a working base which prevent a lot of headaches related to CORS if you're exposing grafana outside a trusted network (at least it gives a base for the configuration minus the SSL bits) and don't want to expose directly your graphite instance.

Collaborator

JonathanTron commented Mar 23, 2014

Hi, thanks for taking the time to send this pull-request.

About the config.js, it's taken from the grafana's config.sample.js and I use it successfully on production with "use strict";, can you explain what don't work for you and with which browser?

About the graphite url change, I'm not convinced. Using directly the graphite host + forcing the port is not acceptable to me. The nginx config I've put in the cookbook is a working base which prevent a lot of headaches related to CORS if you're exposing grafana outside a trusted network (at least it gives a base for the configuration minus the SSL bits) and don't want to expose directly your graphite instance.

@JonathanTron

This comment has been minimized.

Show comment
Hide comment
@JonathanTron

JonathanTron Mar 23, 2014

Collaborator

I closed the PR because I'm not going to merge it, but feel free to continue the discussion here.

Collaborator

JonathanTron commented Mar 23, 2014

I closed the PR because I'm not going to merge it, but feel free to continue the discussion here.

@iiro

This comment has been minimized.

Show comment
Hide comment
@iiro

iiro Mar 23, 2014

With both Firefox (version 27.0.1, Mac) and Chrome (33.0.1750.152) this happens and nothing loads
screen shot 2014-03-23 at 20 37 21 - when I remove the "use strict" everything works normally.

About the CORS things; I understand - I will need to test the setup again using your setup... I completely understand you here.

iiro commented Mar 23, 2014

With both Firefox (version 27.0.1, Mac) and Chrome (33.0.1750.152) this happens and nothing loads
screen shot 2014-03-23 at 20 37 21 - when I remove the "use strict" everything works normally.

About the CORS things; I understand - I will need to test the setup again using your setup... I completely understand you here.

@JonathanTron

This comment has been minimized.

Show comment
Hide comment
@JonathanTron

JonathanTron Mar 23, 2014

Collaborator

Is there any info in the console regarding a javascript error?

Collaborator

JonathanTron commented Mar 23, 2014

Is there any info in the console regarding a javascript error?

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.