New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #13

Merged
merged 15 commits into from Jun 20, 2014

Conversation

Projects
None yet
3 participants
@gregf
Contributor

gregf commented Jun 19, 2014

I been working on cleaning some stuff up in the cookbook and adding some more tests.

One notable change is, I changed the default location from /opt /srv/apps based on FHS.

Just about everything else was test related or rubocop related.

gregf added some commits Jun 18, 2014

Install via file type over git.
Using git master could easily break in between releases. Using the
file method lets us stay on a stable release. It makes the most
sense for a default.
Switch from zip to tar.gz for the default file type.
This makes it so we don't need to install unzip to extract the file.
Most if not all linux servers will come with tar installed.
Block access to config.js from the browser.
config.js could contain username and passwords for graphite and may
contain more sensitive information in the future.
Use /srv rather than /opt
According to FHS /srv is the proper location for www, ftp, and any
other data served by the system.

http://www.pathname.com/fhs/pub/fhs-2.3.html#SRVDATAFORSERVICESPROVIDEDBYSYSTEM
@gregf

This comment has been minimized.

Show comment
Hide comment
@gregf

gregf Jun 19, 2014

Contributor

I should also note I changed the default installation method to file. Using git master is probably a bit risky, a single commit could break things. I switched it over to use the file install_type by default so the cookbook can follow stable releases. Git is always there if someone actually needs it.

Contributor

gregf commented Jun 19, 2014

I should also note I changed the default installation method to file. Using git master is probably a bit risky, a single commit could break things. I switched it over to use the file install_type by default so the cookbook can follow stable releases. Git is always there if someone actually needs it.

@JonathanTron

This comment has been minimized.

Show comment
Hide comment
@JonathanTron

JonathanTron Jun 20, 2014

Collaborator

Thanks for your hard work.

Collaborator

JonathanTron commented Jun 20, 2014

Thanks for your hard work.

JonathanTron added a commit that referenced this pull request Jun 20, 2014

@JonathanTron JonathanTron merged commit 9cb294e into sous-chefs:master Jun 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@gregf

This comment has been minimized.

Show comment
Hide comment
@gregf

gregf Jun 20, 2014

Contributor

Thanks for the merge! 🍻

Contributor

gregf commented Jun 20, 2014

Thanks for the merge! 🍻

@arifcse019

This comment has been minimized.

Show comment
Hide comment
@arifcse019

arifcse019 Apr 10, 2015

Contributor

@gregf Can you please explain a little bit how installation path /opt violates FHS? I checked the relevant section in the document but could not find the answer

Contributor

arifcse019 commented Apr 10, 2015

@gregf Can you please explain a little bit how installation path /opt violates FHS? I checked the relevant section in the document but could not find the answer

@gregf

This comment has been minimized.

Show comment
Hide comment
@gregf

gregf Apr 10, 2015

Contributor

@arifcse019 My thoughts were based on what the definition of /srv says, which can be found here

Which basically says /srv is for site specific data including www, rsync, ftp, and csv. Since we are serving www data I felt /srv is where it belonged.

opt talks about configuration files and static binary packages. I don't see anything that mentions the type of files we're are storing here.

I'm open to other thoughts on the matter though, so let me know if I'm missing something.

Contributor

gregf commented Apr 10, 2015

@arifcse019 My thoughts were based on what the definition of /srv says, which can be found here

Which basically says /srv is for site specific data including www, rsync, ftp, and csv. Since we are serving www data I felt /srv is where it belonged.

opt talks about configuration files and static binary packages. I don't see anything that mentions the type of files we're are storing here.

I'm open to other thoughts on the matter though, so let me know if I'm missing something.

@arifcse019

This comment has been minimized.

Show comment
Hide comment
@arifcse019

arifcse019 Apr 10, 2015

Contributor

Thanks and Disclaimer: I am not a pro in Unix system administration. Just trying to better understand why things are done in certain way.

So under FHS definition. /srv is for data but not the applications that serve those data about the sites hosted on the machine. What do you think?

Contributor

arifcse019 commented Apr 10, 2015

Thanks and Disclaimer: I am not a pro in Unix system administration. Just trying to better understand why things are done in certain way.

So under FHS definition. /srv is for data but not the applications that serve those data about the sites hosted on the machine. What do you think?

@gregf

This comment has been minimized.

Show comment
Hide comment
@gregf

gregf Apr 10, 2015

Contributor

@arifcse019 Sounds good

Contributor

gregf commented Apr 10, 2015

@arifcse019 Sounds good

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.