Add exception handling for JSON::ParserError#155
Merged
scopenco merged 1 commit intosous-chefs:masterfrom Nov 16, 2017
Merged
Conversation
5bb18a2 to
8a4d03c
Compare
scopenco
suggested changes
Nov 15, 2017
Contributor
scopenco
left a comment
There was a problem hiding this comment.
Thank you for PR! Please leave only libraries/organization_api.rb changes and rebase PR.
b93fb0d to
54e4d48
Compare
54e4d48 to
19ac2ff
Compare
Contributor
Author
|
👍 |
scopenco
approved these changes
Nov 16, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add exception handling for JSON::ParserError. Without this exception handling, error is returned on updating resources:
After this, everything is fine, all resources including
grafana_datasource,grafana_user,grafana_dashboard,grafana_organizationare working properly as expected.In addition replacing proper property name for reporting: #156