Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception handling for JSON::ParserError #155

Merged
merged 1 commit into from Nov 16, 2017

Conversation

@ton31337
Copy link
Contributor

commented Dec 7, 2016

Add exception handling for JSON::ParserError. Without this exception handling, error is returned on updating resources:

           Error executing action `update` on resource 'grafana_datasource[prometheus]'
           ================================================================================

           JSON::ParserError
           -----------------
           784: unexpected token at '<*api.NormalResponse Value>'

After this, everything is fine, all resources including grafana_datasource, grafana_user, grafana_dashboard, grafana_organization are working properly as expected.

In addition replacing proper property name for reporting: #156

@ton31337 ton31337 force-pushed the ton31337:Fix/add_json_parse_exception branch 2 times, most recently from 5bb18a2 to 8a4d03c Dec 7, 2016
Copy link
Contributor

left a comment

Thank you for PR! Please leave only libraries/organization_api.rb changes and rebase PR.

@ton31337 ton31337 force-pushed the ton31337:Fix/add_json_parse_exception branch 2 times, most recently from b93fb0d to 54e4d48 Nov 16, 2017
@ton31337 ton31337 force-pushed the ton31337:Fix/add_json_parse_exception branch from 54e4d48 to 19ac2ff Nov 16, 2017
@ton31337

This comment has been minimized.

Copy link
Contributor Author

commented Nov 16, 2017

👍

@scopenco scopenco merged commit ee72909 into sous-chefs:master Nov 16, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ton31337 ton31337 deleted the ton31337:Fix/add_json_parse_exception branch Nov 16, 2017
@lock

This comment has been minimized.

Copy link

commented Nov 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.