Join GitHub today
fix role specification for elasticsearch and graphite #22
This change fixes the ability to dynamically configure the remote end points for graphite and elasticsearch. I could not figure out how the original method was supposed to work given that the
Thanks for the pull-request.
override['grafana']['es_server'] = nil override['grafana']['graphite_server'] = nil
and either use the defaults
I think your change is fine and will apply it with a warning in the README that it will now search for the
added a commit
this pull request
Sep 16, 2014
Jonathan, that makes a little more sense as setting the default to nil did not work for me. I guess using override or normal even would have worked. However the override of each server to nil feels very strange when you're reading the environment/role attributes. I think the update you've merge makes the most sense, but I'm probably biased to that as I wrote the pull request.
Never-the-less thank you for a great cookbook and merging my updates.