Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx template listen_address fix #39

Merged
merged 2 commits into from Apr 1, 2015

Conversation

Projects
None yet
2 participants
@lanyonm
Copy link
Collaborator

commented Mar 30, 2015

This PR contains a fix to the grafana-nginx.conf.erb so that an empty or nil node['grafana']['listen_address'] will render correctly.

It also contains enhanced tests to illustrate #33. Setting node['grafana']['listen_address'] to nil (assuming this patch is accepted) should address the issue discussed in #33.

@JonathanTron

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2015

Thanks for the PR @lanyonm.

JonathanTron added a commit that referenced this pull request Apr 1, 2015

Merge pull request #39 from lanyonm/nginx-ubuntu-1404
nginx template listen_address fix

@JonathanTron JonathanTron merged commit 20772b9 into sous-chefs:master Apr 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lanyonm lanyonm deleted the lanyonm:nginx-ubuntu-1404 branch Apr 1, 2015

@lock

This comment has been minimized.

Copy link

commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.