Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Removing unnecessary services reboots #71

Merged
merged 1 commit into from Aug 7, 2015

Conversation

@HelioCampos
Copy link
Contributor

commented Aug 7, 2015

This PR does the follow:

  1. Fix rubocop complains about unnecessary extra spaces;
  2. Fix rubocop complains about change gsub to tr as we just change one character;
  3. Fix start service failure making it just be restarted at the end of the configuration;
  4. Improve ChefSpec to wait for an specific grafana version according to the version we want to install;
fix_start_service_failure
@HelioCampos

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2015

@JonathanTron,

  • I created a new PR as i had made my changes from the github page. Now I've made all the necessary changes. I also added a change in the before to let we choose the version of the grafana as necessary. Could you tell me if this works for you?

Regards,

@JonathanTron

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2015

Thanks for the changes, I'm reviewing and testing it, once it's done I'll merge it.

@JonathanTron JonathanTron merged commit 651d40c into sous-chefs:master Aug 7, 2015
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@JonathanTron

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2015

Thanks again for working it out!

@lock

This comment has been minimized.

Copy link

commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.