Skip to content

Conversation

@HelioCampos
Copy link

This PR does the follow:

  1. Fix rubocop complains about unnecessary extra spaces;
  2. Fix rubocop complains about change gsub to tr as we just change one character;
  3. Fix start service failure making it just be restarted at the end of the configuration;
  4. Improve ChefSpec to wait for an specific grafana version according to the version we want to install;

@HelioCampos
Copy link
Author

@JonathanTron,

  • I created a new PR as i had made my changes from the github page. Now I've made all the necessary changes. I also added a change in the before to let we choose the version of the grafana as necessary. Could you tell me if this works for you?

Regards,

@JonathanTron
Copy link
Contributor

Thanks for the changes, I'm reviewing and testing it, once it's done I'll merge it.

@JonathanTron JonathanTron merged commit 651d40c into sous-chefs:master Aug 7, 2015
@JonathanTron
Copy link
Contributor

Thanks again for working it out!

@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants