Tuneable, optional storage-schemas/aggregation templates #42

Merged
merged 2 commits into from Apr 10, 2013

Conversation

Projects
None yet
2 participants
@eladroz

eladroz commented Mar 17, 2013

Hi,
See hw-cookbooks#40

  • Default behavior is unchanged.
  • Set ['graphite']['storage_schemas'] or ['storage_aggregation'] to nil to skip handling, but empty array as value would generate an empty file.
  • Array is used because order matters, ruby 1.8 hash iteration is not ordered (for non-omnibus chef with old ruby) & priority field is deprecated in graphite.
  • Chef 11: setting non-nil attribute to nil actually sets the value to empty hash, which should be ignored also.

Oh... forgot to update docs - so if it's ok to merge, tell me and I'd add a doc update commit here.

@webframp

This comment has been minimized.

Show comment Hide comment
@webframp

webframp Apr 10, 2013

Contributor

This looks good.

In the future there's no need to adjust .gitignore with local changes like this, this is easy to modify post merge, but best avoided.

Thanks!

Contributor

webframp commented Apr 10, 2013

This looks good.

In the future there's no need to adjust .gitignore with local changes like this, this is easy to modify post merge, but best avoided.

Thanks!

webframp added a commit that referenced this pull request Apr 10, 2013

Merge pull request #42 from eladroz/master
Tuneable, optional storage-schemas/aggregation templates

@webframp webframp merged commit eeac8eb into sous-chefs:master Apr 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment