New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify windows attributes in attribute files #104

Merged
merged 1 commit into from Dec 17, 2013

Conversation

Projects
None yet
2 participants
@blt04
Contributor

blt04 commented Dec 17, 2013

This fixes a bug introduced in #95. Setting attributes in the recipe (instead of the attribute file) prevents setting default attributes in wrapper cookbooks. I realize this was done so users could easily override jdk_version without having to override all attributes that depend on jdk_version.

This ensures that only attributes which depend on jdk_version are set in the recipe. All other attributes are set in the attribute file like normal.

This fixes windows installations where a user must specify a url and checksum.

Specify windows attributes in attribute files
This moves windows attributes back to the attribute file.
#95 moved these to the recipe,
however that prevents setting these attributes in a wrapper cookbook's
attribute file.

This ensures that only attributes which depend on jdk_version are set
in the recipe.  All other attributes are set in the attribute file like
normal.

carmstrong added a commit that referenced this pull request Dec 17, 2013

Merge pull request #104 from blt04/fix-windows-attrs
Specify windows attributes in attribute files

@carmstrong carmstrong merged commit d4b543e into sous-chefs:master Dec 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment