New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest windows and aws #117

Merged
merged 1 commit into from Jan 14, 2014

Conversation

Projects
None yet
3 participants
@tdg5
Contributor

tdg5 commented Jan 14, 2014

Related to #92, it seems to me that full fledged dependencies on aws and windows is excessive for pure Linux environments.

As suggested by @carmstrong, this change moves from depends to suggests for both aws and windows.

YMMV, but switching to suggests moved my chef setup from failing to compile (even though I cloned down the aws and windows cookbooks), to a working state where I am able to compile and run successfully.

If this patch is accepted, it should resolve #92 as well.

@tdg5

This comment has been minimized.

Contributor

tdg5 commented Jan 14, 2014

I created a JIRA issue linking to this PR which can be found here: https://tickets.opscode.com/browse/COOK-4216

@carmstrong

This comment has been minimized.

Contributor

carmstrong commented Jan 14, 2014

Looks good. My only concern was that suggests was added in a relatively recent Chef client release, but it looks like it's been there for almost 3 years.

carmstrong added a commit that referenced this pull request Jan 14, 2014

@carmstrong carmstrong merged commit ce73d48 into sous-chefs:master Jan 14, 2014

@mveitas

This comment has been minimized.

mveitas commented on 90ecd3d Jan 22, 2014

Just curious as to why the change from depends to suggests?

I was just looking at the spec tests, and now that the cookbook only suggests 'windows', it no longer has a reference to the helper method, win_friendly_path.

This comment has been minimized.

Contributor

carmstrong replied Jan 22, 2014

aws and windows are only used by the windows flavor cookbook, and it didn't make sense to force them to be installed by people on other platforms. There was also a recent issue with the windows cookbook that caused a circular dependency (I think with the powershell cookbook) which caused even more frustration for java cookbook users.

The spec tests need to be completely rewritten: #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment