Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix JDK install on Windows. #131
I think that #100 broke the windows install when using a JDK installer.
For example, if I download both a JRE and a JDK here : http://www.oracle.com/technetwork/java/javase/downloads/jdk7-downloads-1880260.html and here http://java.com/en/download/manual.jsp#win
.\jdk-7u51-windows-x64.exe /s INSTALLDIR="C:\java"
The second one works, but the first one doesn't. It does when I remove the backward slashes.
The fix seems to be http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4966488
I tested this change with both a JDK and a JRE installer, and both were correctly installed.
My first thought is that this isn't necessary a bug - this cookbook aims to install the JDK for all platforms, not the JRE package, which will probably break other recipes as well. That said, I am not necessarily opposed to this change, as long as it doesn't break the installation of the JDK.
Have you tested this change on Windows by setting
Unfortunately I don't think we can run automated tests on Windows like we can on other platforms.. :(
Just to be clear : in my case, the JDK install was broken, and the JRE install worked. My change fixes it for the JDK install.
Yes, I have tested by overridding the