New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow jdk_version to be a string or number #133

Merged
merged 1 commit into from Jan 24, 2014

Conversation

Projects
None yet
1 participant
@carmstrong
Contributor

carmstrong commented Jan 24, 2014

Previously, the case statements checking the jdk_version failed
because they were assuming jdk_version was a string. For users overriding
this value and setting it to be a number, the case statement would never
match. This commit ensures we are always using a string when comparing
jdk_version.

Allow jdk_version to be a string or number
Previously, the case statements checking the jdk_version failed
because they were assuming jdk_version was a string. For users overriding
this value and setting it to be a number, the case statement would never
match. This commit ensures we are always using a string when comparing
jdk_version.

carmstrong added a commit that referenced this pull request Jan 24, 2014

Merge pull request #133 from socrata-cookbooks/fix_jdk_version_string
Allow jdk_version to be a string or number

@carmstrong carmstrong merged commit 9997f77 into master Jan 24, 2014

@carmstrong carmstrong deleted the fix_jdk_version_string branch Jan 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment