New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the default-java symlink to Oracle JDK #143

Merged
merged 2 commits into from Mar 15, 2014

Conversation

Projects
None yet
3 participants
@mbautin

mbautin commented Mar 3, 2014

No description provided.

@carmstrong

This comment has been minimized.

Contributor

carmstrong commented Mar 3, 2014

I was thinking about this myself after cutting the last release. I'm thinking we should refactor these into a new recipe called default_java_symlink.rb or something, and then include_recipe that in both of these locations. Care to update this PR with that change?

@mbautin

This comment has been minimized.

mbautin commented Mar 3, 2014

Updated with the refactoring. Also added the same fix to oracle_i386.

@carmstrong

This comment has been minimized.

Contributor

carmstrong commented Mar 4, 2014

Looks good, but we can pull the tests out of oracle_spec and oracle_i386_spec into a new default_java_symlink_spec.

@billmoritz

This comment has been minimized.

billmoritz commented Mar 14, 2014

(+1)

carmstrong added a commit that referenced this pull request Mar 15, 2014

Merge pull request #143 from mbautin/default-java
Add the default-java symlink to Oracle JDK

@carmstrong carmstrong merged commit 88f8dbb into sous-chefs:master Mar 15, 2014

carmstrong added a commit that referenced this pull request Mar 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment