New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Test Kitchen suites #151

Merged
merged 1 commit into from Mar 21, 2014

Conversation

Projects
None yet
3 participants
@hectcastro
Contributor

hectcastro commented Mar 20, 2014

This pull request updates the format and operating system versions for the Test Kitchen suites.

carmstrong added a commit that referenced this pull request Mar 21, 2014

@carmstrong carmstrong merged commit d78ce8a into sous-chefs:master Mar 21, 2014

- name: ubuntu-13.10
driver:
box: opscode-ubuntu-13.10
box_url: http://opscode-vm-bento.s3.amazonaws.com/vagrant/virtualbox/opscode_ubuntu-13.10_chef-provisionerless.box

This comment has been minimized.

@juliandunn

juliandunn Mar 21, 2014

Member

It's not necessary to list box URLs in here; in fact, it's probably not recommended, because it locks people into Virtualbox. If they want to use vagrant with VMware, they are SOL

This comment has been minimized.

@hectcastro

hectcastro Mar 21, 2014

Contributor

How do you cover both? Or is that idea that you don't and defer that to .kitchen.local.yml?

This comment has been minimized.

@juliandunn

juliandunn Mar 21, 2014

Member

I'm not sure, I'd need to dig around in the Test Kitchen code to see what it's doing.

This comment has been minimized.

@carmstrong

carmstrong Mar 22, 2014

Contributor

I'm cutting a release as we have some good changes ready to go out, but I agree that this should handle VMWare as well, if possible. Will probably need some help on that, @juliandunn

This comment has been minimized.

@juliandunn

juliandunn Mar 22, 2014

Member

@carmstrong @hectcastro So I read the code in the kitchen-vagrant driver and there is logic to handle this:

https://github.com/test-kitchen/kitchen-vagrant/blob/master/lib/kitchen/driver/vagrant.rb#L108-L114

so if you're using vmware as a driver it will automagically pick the right bucket to grab the Bento boxes from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment