New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VirtualBox specific box_urls #157

Merged
merged 2 commits into from Mar 23, 2014

Conversation

Projects
None yet
4 participants
@hectcastro
Contributor

hectcastro commented Mar 22, 2014

The Vagrant driver for Test Kitchen can automatically detect provisioner type and associated Bento box based on suite name.

See also: https://github.com/test-kitchen/kitchen-vagrant/blob/v0.14.0/lib/kitchen/driver/vagrant.rb#L108-L114

/cc @juliandunn

Remove VirtualBox specific box_urls
The Vagrant driver for Test Kitchen can automatically detect provisioner
type and Bento box based on suite name.
@juliandunn

View changes

.kitchen.yml Outdated
@@ -1,7 +1,6 @@
---
driver:
name: vagrant
require_chef_omnibus: true

This comment has been minimized.

@juliandunn

juliandunn Mar 23, 2014

Member

Unclear why you're removing this @hectcastro ?

This comment has been minimized.

@hectcastro

hectcastro Mar 23, 2014

Contributor

Mistakenly thought this was a deprecated kitchen-vagrant setting, but appears to be a valid test-kitchen setting.

carmstrong added a commit that referenced this pull request Mar 23, 2014

Merge pull request #157 from hectcastro/hc-kitchen-box-url
Remove VirtualBox specific box_urls

@carmstrong carmstrong merged commit 9c9dac7 into sous-chefs:master Mar 23, 2014

@@ -12,45 +12,37 @@ platforms:
- name: ubuntu-13.10
driver:
box: opscode-ubuntu-13.10

This comment has been minimized.

@jspiewak

jspiewak Mar 23, 2014

The box name can be determined as well, the whole driver section could be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment