New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for MD5 checksum #99

Merged
merged 1 commit into from Dec 19, 2013

Conversation

Projects
None yet
2 participants
@st-h
Contributor

st-h commented Nov 25, 2013

Oracle provides MD5 checksum for jdk downloads: http://www.oracle.com/technetwork/java/javase/downloads/java-se-binaries-checksum-1956892.html
The cookbook currently only supports SHA256. This pull request parses the format of the checksum and automatically uses SHA256 or MD5 to verify the downloaded file. That way the checksum provided by oracle may be used directly, while maintaining support for SH256.

@carmstrong

This comment has been minimized.

Contributor

carmstrong commented Dec 18, 2013

Curious what others think of this. It looks like Oracle only provides MD5 hashes. Should we change the cookbook to validate on MD5 only, or do we trust the SHA256 that we generate manually with each release?

@st-h

This comment has been minimized.

Contributor

st-h commented Dec 18, 2013

To make it easy and have backwards compatibility, this PR supports both and chooses the appropriate method depending on the format of the checksum.

carmstrong added a commit that referenced this pull request Dec 19, 2013

@carmstrong carmstrong merged commit e43e80d into sous-chefs:master Dec 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment