Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scl installation recipe #149

Merged
merged 3 commits into from Mar 15, 2017
Merged

scl installation recipe #149

merged 3 commits into from Mar 15, 2017

Conversation

dimsh99
Copy link
Contributor

@dimsh99 dimsh99 commented Mar 13, 2017

Recipe and attributes to install mariadb from Software Collections repository on centos6/7. I'm sorry for creating new PR instead of reopening #148 .

@shoekstra
Copy link
Contributor

shoekstra commented Mar 14, 2017

@dimsh99 looks good! Can you please address the Foodcritic error:

FC048: Prefer Mixlib::ShellOut: /home/travis/build/sinfomicien/mariadb/providers/replication.rb:33

Once this has been fixed it's good to merge 👍

@dimsh99 dimsh99 closed this Mar 14, 2017
@dimsh99 dimsh99 reopened this Mar 14, 2017
@dimsh99
Copy link
Contributor Author

dimsh99 commented Mar 14, 2017

Should be fixed. I think mysql2_gem interface is more flexible and switching to it instead of /usr/bin/mysql execution would be beneficial for the cookbook. I have some drafts for this. Let me know if there are any objections.

@shoekstra shoekstra merged commit b4462c4 into sous-chefs:master Mar 15, 2017
@shoekstra
Copy link
Contributor

Thanks! Great contribution.

Re using mysql2_gem, agreed, it was on the consideration list for the v2.0 rewrite to use custom resources.

if you already have something then sure am interested 👍

@shoekstra
Copy link
Contributor

This has been included in v1.2.0 in the Supermarket.

@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants