Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CircleCI #559

Merged
merged 35 commits into from Sep 25, 2018

Conversation

Projects
None yet
2 participants
@damacus
Copy link
Member

damacus commented Sep 2, 2018

Description

Add CircleCI testing

Issues Resolved

Build failures in Travis

Contribution Check List

  • All tests pass.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable

@damacus damacus force-pushed the circleci branch from 0fbfd97 to 67626e8 Sep 2, 2018

Add CircleCI
- Add Dangerfile

@damacus damacus force-pushed the circleci branch from 67626e8 to 551b65c Sep 2, 2018

@damacus damacus force-pushed the circleci branch 3 times, most recently from ac14765 to b33b12f Sep 2, 2018

Install Chef
# Explain why this change is being made

# Provide links to any relevant tickets, articles or other resources

@damacus damacus force-pushed the circleci branch from b33b12f to acbe62a Sep 2, 2018

damacus added some commits Sep 2, 2018

Remove RVM
# Explain why this change is being made

# Provide links to any relevant tickets, articles or other resources
Set GEM paths
# Explain why this change is being made

# Provide links to any relevant tickets, articles or other resources

@damacus damacus force-pushed the circleci branch from 970a670 to a828b38 Sep 2, 2018

Test repositories
Use workspaces to persist install

@damacus damacus force-pushed the circleci branch 4 times, most recently from b6944a2 to 618cc9d Sep 2, 2018

Kitchen test
Kitchen test and filter on job name

@damacus damacus force-pushed the circleci branch 2 times, most recently from 59e3900 to efe145f Sep 2, 2018

Separate platforms into their own stages
# Explain why this change is being made

# Provide links to any relevant tickets, articles or other resources

@damacus damacus force-pushed the circleci branch from efe145f to 39a8dec Sep 3, 2018

Full names for stages now
# Explain why this change is being made

# Provide links to any relevant tickets, articles or other resources

@damacus damacus force-pushed the circleci branch from c016a2f to 7a4dfd4 Sep 3, 2018

damacus added some commits Sep 3, 2018

Set locale on template and new databases
Unless specified initdb locale takes the local from the system DB which is different depending on CI system, local system
CHANGELOG update
# Explain why this change is being made

# Provide links to any relevant tickets, articles or other resources
Fix initdb_locale for extension resource
# Explain why this change is being made

# Provide links to any relevant tickets
deduplicate install chef section
# Explain why this change is being made

# Provide links to any relevant tickets, articles or other resources

@damacus damacus force-pushed the circleci branch from 24985c1 to a136318 Sep 3, 2018

damacus added some commits Sep 7, 2018

Don't stop believin'
Hold on to the feelin'

@damacus damacus requested review from tas50 and josephholsten Sep 24, 2018

@majormoses
Copy link
Member

majormoses left a comment

Don't know much about circle CI setup or dangerfile bit it looks sane.


# Require a CHANGELOG entry for non-test changes.
if !git.modified_files.include?('CHANGELOG.md') && code_changes?
raise 'Please include a [CHANGELOG](https://github.com/sous-chefs/line-cookbook/blob/master/CHANGELOG.md) entry.'

This comment has been minimized.

@majormoses

majormoses Sep 24, 2018

Member

should we maybe have a repo for community/documentation stuff to avoid duplication or linking to one random cookbook? In the sensu community we have https://github.com/sensu-plugins/community where we include contributing docs, changelog guidelines, versioning guidelines, PR processes, etc.

@damacus

This comment has been minimized.

Copy link
Member Author

damacus commented Sep 24, 2018

ah hah, you're talking about either meta or website then I think!

Hopefully once circleci orbs come out of preview, I can roll this out further and reduce duplication between repos.

At that point it'll be a copy 'n paste of a workflow

@damacus damacus merged commit ed8ac43 into master Sep 25, 2018

9 checks passed

ci/circleci: Danger Your tests passed on CircleCI!
Details
ci/circleci: Lint Your tests passed on CircleCI!
Details
ci/circleci: access Your tests passed on CircleCI!
Details
ci/circleci: client-install Your tests passed on CircleCI!
Details
ci/circleci: ident Your tests passed on CircleCI!
Details
ci/circleci: initdb Your tests passed on CircleCI!
Details
ci/circleci: repo Your tests passed on CircleCI!
Details
ci/circleci: server-install Your tests passed on CircleCI!
Details
danger/danger All green. Nice work.

@damacus damacus deleted the circleci branch Sep 25, 2018

gionn added a commit to gionn/postgresql that referenced this pull request Sep 26, 2018

Add CircleCI (sous-chefs#559)
* Install Chef using omnibus
* Unless specified initdb locale takes the local from the system DB which is different depending on CI system, local system
* Add ORBs
* Add repo suite
* Fedora latest instead of fedora-28
 Remove extension test as it's broken right now
* Remove travis.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.