Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Renamed example configuration to listen_addresses #57

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
Contributor

tpett commented May 8, 2013

The example used the configuration option "listen_address" which isn't correct. The correct configuration option is "listen_addresses". It doesn't affect the point the config is trying to make, but it is misleading for someone searching for that particular option.

@tpett tpett Renamed example configuration to listen_addresses
The example used the configuration option "listen_address" which isn't correct. The correct configuration option is "listen_addresses". It doesn't affect the point the config is trying to make, but it is misleading for someone searching for that particular option.
0c49972

biinari commented May 30, 2013

👍

+1

Hey @tpett! Thank you for supporting the Opscode Cookbooks! Opscode's process has a couple prerequisites before they will merge your contribution. We need to ensure you've completed a Contributor License Agreement (CLA) and a ticket on their ticket tracker for the release workflow. Pull requests are optional, but should always include the ticket number that they're related to for cross-referencing. Please take a moment to review the below wiki page for the appropriate steps:

Contributor

tpett commented Sep 4, 2013

Wow. That is absolutely ludicrous. It's literally a 4 character change to documentation. I signed your silly CLA and created an account...

@tpett - I totally agree with you but Opscode is trying to cover themselves from a legal standpoint. Can you please link the ticket here and ensure its status is "Fix Provided?" Thanks!

Contributor

tpett commented Sep 4, 2013

I created a ticket. I don't see how to get it into that state. The furthest I could get is "In progress".

https://tickets.opscode.com/browse/COOK-3555

@tpett - It takes a bit while Opcsode legal approves your CLA submission. I marked the ticket as "Fix Provided" so that it will go under Opscode's radar. Thanks for your contribution!

Contributor

tpett commented Sep 4, 2013

Glad to help! Thanks for enduring the mire of legal stuff to get changes pulled into the repos, @jesseadams. You're a better human than me. :-P

Contributor

btm commented Sep 9, 2013

👍

Contributor

sethvargo commented Sep 10, 2013

Merged in acdc1b5

@sethvargo sethvargo closed this Sep 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment