New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make notify calls explicit #10

Merged
merged 2 commits into from May 22, 2013

Conversation

Projects
None yet
2 participants
@tsabat
Contributor

tsabat commented May 15, 2013

The version of Chef that AWS's OpsWorks employs does not handle the notifies calls with implicit resource shortcuts. This issue is outlined here.

Accepting this pull request will not materially change the makeup of the cookbook and will ease the bleeding-edge users of AWS OpsWorks. Ultimately, OpsWorks will upgrade Chef and this will be a non-issue. But, until then, this pull request will help myself and others.

fnichol added a commit that referenced this pull request May 22, 2013

Merge pull request #10 from CodePen/master
Use old-form notifies to support AWS OpsWorks.

@fnichol fnichol merged commit 5d1a556 into sous-chefs:master May 22, 2013

1 check failed

default The Travis CI build failed
Details

fnichol added a commit that referenced this pull request May 22, 2013

@fnichol

This comment has been minimized.

Show comment
Hide comment
@fnichol

fnichol May 22, 2013

Collaborator

Looks good to me, thank you!!

Collaborator

fnichol commented May 22, 2013

Looks good to me, thank you!!

@tsabat

This comment has been minimized.

Show comment
Hide comment
@tsabat

tsabat May 22, 2013

Contributor

thanks. they are using chef v9, so there will be oddities here an there. I want an upgrade now. In the meanwhile, you're doing the world a favor. Thanks.

Contributor

tsabat commented May 22, 2013

thanks. they are using chef v9, so there will be oddities here an there. I want an upgrade now. In the meanwhile, you're doing the world a favor. Thanks.

@fnichol

This comment has been minimized.

Show comment
Hide comment
@fnichol

fnichol May 23, 2013

Collaborator

Well thank you for doing the hard work tracking this down

Collaborator

fnichol commented May 23, 2013

Well thank you for doing the hard work tracking this down

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.