os x compliance #2

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

rweng commented Jan 18, 2012

I am currently using littlechef to configure my local machine. rbenv is one of my cookbooks. Although not being used for my local machine, it throws an exception. It seems, the libraries are not automatically included because I do not use the cookbook, but somehow the provider is required. Because the mixin and script_helpers was not required before, the provider throws an exception.

Contributor

fnichol commented Jan 23, 2012

Right! I had this issue in a couple of other cookbooks due to the way/order that Chef loads in libraries/ code. Are you able to double check if the above patch gets the job done? Thanks!

rweng commented Jan 23, 2012

This patch does eliminate the error that is thrown when the cookbook is synchronized to a node. It does not, however, make the cookbook run on OS X (at least I did not test that yet, though I am going to do that later).

I used chef-rbenv with this patch on an ubuntu machine, continues to work fine. So it should be safe to merge it in. I might send another pull-request later to provide support for OS X, if necessary.

Fletcher, your cookbooks are among the most stable and well designed cookbooks I've seen, thanks for that.

Contributor

fnichol commented Feb 20, 2012

@rweng Thanks for your feedback! I'll be trying this cookbook out on a mac in the next week or so and will try to update with anything missing. The mac should be a first-class supported platform. If you find anything further, just open a new issue and we'll deal with it.

fnichol closed this Feb 20, 2012

@GUI GUI pushed a commit to NREL-cookbooks/rbenv that referenced this pull request Mar 10, 2013

@reset reset Merge pull request #2 from RiotGames/group_error
Create rbenv group before rbenv user
0baf55a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment