Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWRP Refactor #235

Merged
merged 22 commits into from Oct 2, 2014
Merged

LWRP Refactor #235

merged 22 commits into from Oct 2, 2014

Conversation

@martinisoft
Copy link
Contributor

@martinisoft martinisoft commented Nov 6, 2013

Pulling this into a pull request now to re-gain some momentum on this branch and get it ready for a release. This will supersede a lot of the pull requests currently out there and should help resolve many of the issues going on currently with the cookbook. Much of the issues stem from the coupling to the rvm gem so this re-factor helps de-couple the rvm gem dependency and create an LWRP around setup and installation.

On the to-do list:

Cookbook Specs:

  • Resolve Travis-CI build issues

Test-Kitchen Integration Suite:

  • stock-system-and-user-ubuntu-1404
  • stock-system-and-user-ubuntu-1204
  • stock-system-and-user-ubuntu-1004
  • stock-system-and-user-ubuntu-1004
  • stock-system-and-user-debian-76
  • stock-system-and-user-centos-64
  • rubies-ubuntu-1404
  • rubies-ubuntu-1204
  • rubies-ubuntu-1004
  • rubies-ubuntu-1004
  • rubies-debian-76
  • rubies-centos-64
  • rbx-ubuntu-1404
  • rbx-ubuntu-1204
  • rbx-ubuntu-1004
  • rbx-debian-76
  • rbx-centos-64
  • installs-ubuntu-1404
  • installs-ubuntu-1204
  • installs-ubuntu-1004
  • installs-debian-76
  • installs-centos-64
fnichol and others added 6 commits Sep 7, 2013
This is a nontrivial update and not 100% backwards compatible.
This is now set to 'ruby' which will always be the latest version and
patch release of ruby according to the current version of RVM being
installed. Overall, this is a more sensible future-proof default than
constantly updating patch levels in the default attributes.
@martinisoft martinisoft mentioned this pull request Dec 27, 2013
@martinisoft
Copy link
Contributor Author

@martinisoft martinisoft commented Dec 27, 2013

Currently blocked on this due to a weird sudoers bug with the Ubuntu base boxes. I have filed a bug for the Bento project here and will investigate hacking this for the time being with the sudo cookbook. The problem I hit was attempting to verify the user/system install cookbook and running the BATS tests to execute the commands as the wigglebottom user. You're not allowed to with the current sudo permissions on the 13.04 basebox.

martinisoft added 3 commits Dec 27, 2013
It will fail due to a missing apt mirror and it needs updating before
attempting to install a few packages.
1.8.7 is officially EOL so it will slowly be removed from the
integration suite.
This will help better test the system and user based installs of rvm
because it will need sudo access in order to execute any of the rvm
commands as that user for the user installation.
@martinisoft
Copy link
Contributor Author

@martinisoft martinisoft commented Dec 27, 2013

Even with a temporary fix, the user installation LWRP isn't working correctly in the rvm::user_install cookbook.

@martinisoft
Copy link
Contributor Author

@martinisoft martinisoft commented Dec 29, 2013

Updated the PR with a checklist of the Test Suites that need to pass. Will need to also gather a breaking-change note set for the 1.0 release after this hits master.

martinisoft added 7 commits Feb 17, 2014
Conflicts:
	Gemfile
	README.md
	libraries/chef_rvm_recipe_helpers.rb
Conflicts:
	README.md
	Rakefile
	attributes/default.rb
14.04 is the latest Ubuntu LTS as 13.04 was EOL as of Jan 2014.

Debian 7.1.0 is no longer available
@martinisoft martinisoft added this to the Release 1.0 milestone Sep 2, 2014
@martinisoft martinisoft changed the title A nontrivial refactor LWRP Refactor Sep 2, 2014
martinisoft added a commit that referenced this issue Oct 2, 2014
@martinisoft martinisoft merged commit 3950f22 into master Oct 2, 2014
1 check passed
@martinisoft martinisoft deleted the a-nontrivial-refactor branch Oct 2, 2014
cmluciano pushed a commit to cmluciano/chef-rvm that referenced this issue Mar 11, 2015
This commit utilizes the newer methods of defining home and user in
accordance with
[PR235](sous-chefs#235)
@cmluciano cmluciano mentioned this pull request Mar 11, 2015
@lock
Copy link

@lock lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants