New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samba custom resources #42
Conversation
Remove server attributes Remove attributes out of template file and into template resource
@@ -13,7 +19,7 @@ Installs and configures Samba daemon. Uses Chef Server for data bag to build con | |||
|
|||
### Chef | |||
|
|||
- Chef 11+ | |||
- Chef 12.5+ |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
You can disable FC016 with a .foodcritic file since it doesn't know how to deal with custom resources |
Update README with intent having a default recipe can be misleading
Guard against nil options & shares Fix mishaving foodcritic
Installs and configures Samba daemon. Uses Chef Server for data bag to build configuration file shares. Includes a resource for adding / removing Samba users. | ||
Installs and configures Samba daemon. Uses Chef Server for data bag to build configuration file shares. | ||
|
||
# Resources |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Rename server to share_name Because server_name really didn't make any sense
You can probably delete a good chunk of the chefspecs for now |
@@ -9,10 +9,12 @@ | |||
recipe 'samba::client', 'Installs smbclient package' | |||
recipe 'samba::server', 'Installs samba server packages and configures smb.conf' | |||
|
|||
%w( debian ubuntu centos fedora redhat scientific amazon oracle ).each do |os| |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Use root context for template and services Remove data bags!
InSoec tests passing for all platforms - tidy up metadata
Looks like all the conflicts are files I've gone ahead and deleted. |
The current issue is nmb doesn't start on systemd as it can't find an available local interface in Vagrant. |
@@ -1,3 +1,3 @@ | |||
execute 'apt-get update' if platform_family?('debian') | |||
apt_update 'update' if platform_family?('debian') |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
property :config_file, String, default: '/etc/samba/smb.conf' | ||
property :samba_services, Array, default: lazy { | ||
case node['platform'] | ||
when 'rhel', 'fedora', 'centos' |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
property :create_mask, String, required: true # e.g. 0644 | ||
property :directory_mask, String, required: true # e.g. 0700 | ||
property :config_file, String, default: lazy { | ||
if node['platform_family'] == 'smartos' |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
chef_version '>= 12.1' if respond_to?(:chef_version) | ||
|
||
depends 'compat_resource', '>= 12.16.3' | ||
depends 'yum' |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
samba_server #36 :
samba_share
accumulation)samba_share #35 :