Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMake the TLS certificate management optional #13
Conversation
This comment has been minimized.
This comment has been minimized.
|
I am going to need to think about this a little bit further. I am trying to keep direct node access from within the library itself. If we do this I would prefer feeding it in as a resource attribute name. |
jeffbyrnes
force-pushed the
evertrue:manage_certificate_optional
branch
from
9fe9c2d
to
7775850
This comment has been minimized.
This comment has been minimized.
|
@johnbellone as in, you do not want to access node attributes from within the library, but instead pass them in via the resource’s attributes? E.g., vault_config 'xyz' do
# other attributes
manage_cert false
end |
This comment has been minimized.
This comment has been minimized.
|
@jeffbyrnes Yes, correct. |
The prescription by this cookbook to manage the TLS certificate, using chef-vault, is overly strong, and, while it is an excellent practice, may not jibe with some potential users’ workflows. Tests for the two logic flows in disabling the certificate management are also present.
jeffbyrnes
force-pushed the
evertrue:manage_certificate_optional
branch
from
7775850
to
1b24cc9
This comment has been minimized.
This comment has been minimized.
|
@johnbellone ok, I think that should do the trick. I’ve rebased it onto the current master, and added integration tests as well. |
Make the TLS certificate management optional
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 19, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
jeffbyrnes commentedAug 23, 2015
The prescription by this cookbook to manage the TLS certificate, using chef-vault, is overly strong, and, while it is an excellent practice, may not jibe with some potential users’ workflows.
Builds on #4 to use the
VaultConfig#tls?method to control whether or not the certificate files are managed. All credit to @zarry!